New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send numbers or bools as payloads #1609
Conversation
@retrohacker is master still our target for 6.x? I see the new middleware/routing system is targeted to land on next. |
510718e
to
69f709d
Compare
Sorry @hekike I had to remove your fancy variadic parsing - doesn't seem possible to disambiguate a bool payload from the format arg! |
tools/mk/Makefile.targ
Outdated
@@ -122,6 +122,10 @@ check-bash: $(BASH_FILES:%=%.bashchk) $(BASH_FILES:%=%.bashstyle) | |||
%.bashstyle: % | |||
$(BASHSTYLE) $^ | |||
|
|||
.PHONY: check-eslint-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a make fix-style
that reprints everything with prettier
, probably more accurate than ESLint fix: https://github.com/restify/node-restify/blob/master/tools/mk/Makefile.targ#L137
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice! I completely forgot you added that! I'll remove this target 👍
Fixes #1461 and #1607